am243x_evm/am2434/r5f0_0: TI ADC cleanup #92170
Open
+190
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Samples
natto1784
changed the title
github-actions
bot
added
the
platform: TI SimpleLink
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
vaishnavachath
previously approved these changes
Jul 7, 2025
Contributor
Author
|
resolved conflicts |
JarmouniA
requested changes
Aug 26, 2025
Contributor
Author
|
done |
Contributor
Contributor
Author
|
thanks, changed |
JarmouniA
previously requested changes
Aug 28, 2025
samples/drivers/adc/adc_sequence/boards/am243x_evm_am2434_r5f0_0.overlay
Show resolved
Hide resolved
|
natto1784
force-pushed
the
adc_cleanup
branch
from
cd6bb2f to
43c555f
Compare
natto1784
force-pushed
the
adc_cleanup
branch
from
43c555f to
c092838
Compare
natto1784
force-pushed
the
adc_cleanup
branch
from
c092838 to
ba8cd9f
Compare
|
Change the ADC reference for channels from internal to VDD. This involves removing the present binding to get the internal reference. Signed-off-by: Amneesh Singh <[email protected]>
ADC channel nodes should not belong to the board device tree definition and hence, remove them. Signed-off-by: Amneesh Singh <[email protected]>
Update the sample overlays to match the current ADC device driver bindings. Signed-off-by: Amneesh Singh <[email protected]>
natto1784
force-pushed
the
adc_cleanup
branch
from
ba8cd9f to
976fa71
Compare
natto1784
force-pushed
the
adc_cleanup
branch
2 times, most recently
from
9295783 to
ab9efa2
Compare
natto1784
changed the title
Contributor
Author
|
rebased and added a couple more changes |
Support configuration of pins for ADC channels in the driver. Signed-off-by: Amneesh Singh <[email protected]>
Add the missing pins for ADC0 channels in the main domain. Signed-off-by: Amneesh Singh <[email protected]>
natto1784
force-pushed
the
adc_cleanup
branch
from
ab9efa2 to
7a74d57
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ADC reference for channels from internal to VDD.
Move the child nodes for ADC from board device tree to ADC sample overlays as the board should not define any channels by default.
Add pinctrl support for the TI ADC driver
Add pins for ADC0 channels